-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test to dataset name cache #124
Conversation
until epics-base/p4p#145 is fixed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #124 +/- ##
==========================================
+ Coverage 90.94% 91.31% +0.36%
==========================================
Files 8 8
Lines 1358 1358
Branches 213 213
==========================================
+ Hits 1235 1240 +5
+ Misses 83 80 -3
+ Partials 40 38 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine but there's a couple of possible improvements that could be made
@@ -313,13 +313,18 @@ def handle_data(self, data: HDFReceived): | |||
|
|||
@dataclass | |||
class Dataset: | |||
"""A dataset name and capture mode""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is a "Dataset" in this context? I don't know enough about this area to know if this is a commonly known topic, or a concept created here for our code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's more of an abstraction - we have the BLOCK_NAME:DATASET
record for using an alternative column label in the hdf5 file and the BLOCK_NAME:CAPTURE
record for specifying what is captured. class Dataset
functions as a more readable way to keep these together in the dict given from ioc.py
.
aedc9b6
to
ad1d097
Compare
changed `DATASET` pvi table to `r` instead of `rw` changed capture to combobox in positions capture table
ad1d097
to
339ae3a
Compare
Adds a test to dataset name cache.
Also
:CAPTURE
to aComboBox
widget in the positions capture table.